Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter] Continue DataType rename in exporter #11305

Conversation

TylerHelmuth
Copy link
Member

Description

Continues DataType deprecation/rename in exporter for Settings.DataType and CheckConsumeContractParams.DataType.

Link to tracking issue

Related to #9429

@TylerHelmuth TylerHelmuth requested a review from a team as a code owner September 30, 2024 17:18
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [api]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line. and everywhere.

@bogdandrutu bogdandrutu merged commit 3037b26 into open-telemetry:main Sep 30, 2024
47 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.41%. Comparing base (bce1040) to head (f3fceab).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11305   +/-   ##
=======================================
  Coverage   91.40%   91.41%           
=======================================
  Files         424      424           
  Lines       20222    20219    -3     
=======================================
- Hits        18484    18483    -1     
+ Misses       1355     1354    -1     
+ Partials      383      382    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jackgopack4 pushed a commit to jackgopack4/opentelemetry-collector that referenced this pull request Oct 8, 2024
#### Description

Continues DataType deprecation/rename in exporter for
`Settings.DataType` and `CheckConsumeContractParams.DataType`.

#### Link to tracking issue
Related to
open-telemetry#9429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants